Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63740 )
Change subject: [UNTESTED]acpi/acpi.h: Fix size of VFCT table ......................................................................
[UNTESTED]acpi/acpi.h: Fix size of VFCT table
Having u8 in the acpi_vfct_image_hdr_t could produce an off by one error or at least use 1 byte more than necessary.
Change-Id: Ic984b1515fe13062f58ce4e54ef51c8d02663d92 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/63740/1
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index dbd5c38..0a5230c 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -408,7 +408,7 @@ u16 SSID; u32 Revision; u32 ImageLength; - u8 VbiosContent; // dummy - copy VBIOS here + u8 VbiosContent[0]; // dummy - copy VBIOS here } __packed acpi_vfct_image_hdr_t;
/* VFCT (VBIOS Fetch Table) */