Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )
Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers
......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/inventec/transformers/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75598/comment/21e1879c_c328ffc1 :
PS5, Line 23: * For ArcherCity CRB, only SUART1 is used.
This seems copy-pasted.
Yeah, parts will be factored out (same with CB:75722).
File src/mainboard/inventec/transformers/romstage.c:
https://review.coreboot.org/c/coreboot/+/75598/comment/61cd28f1_18e4d14f :
PS5, Line 102: selftest result first */
Please align the line correctly.
Done
https://review.coreboot.org/c/coreboot/+/75598/comment/587e0557_bfab73cc :
PS5, Line 118: /* Enable - Portions of memory reference code will be skipped */
: /* when possible to increase boot speed on warm boots.*/
: /* Disable - Disables this feature. */
: /* Auto - Sets it to the MRC default setting. */
Please use the multi-line commenting style listed in the coding style.
Done
https://review.coreboot.org/c/coreboot/+/75598/comment/b94ec765_46eabf7a :
PS5, Line 142: /* Disable FSP memory train results*/
Please add a space at the end.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75598?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684
Gerrit-Change-Number: 75598
Gerrit-PatchSet: 8
Gerrit-Owner: Annie Chen
chen.annieet@inventec.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Wei Chen
Chen.HW@inventec.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Wei Chen
Chen.HW@inventec.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Annie Chen
chen.annieet@inventec.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Thu, 29 Jun 2023 00:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment