Attention is currently required from: Hung-Te Lin.
Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72869 )
Change subject: soc/mediatek: Remove unnecessary !! for boolean variable ......................................................................
soc/mediatek: Remove unnecessary !! for boolean variable
Enable is already a boolean, so the !! is not needed.
BUG=None TEST=build pass.
Change-Id: I25a7cec632f21a258b8364c82e25b59e55ab7453 Signed-off-by: Liju-Clr Chen liju-clr.chen@mediatek.com --- M src/soc/mediatek/common/mt6359p.c 1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/72869/1
diff --git a/src/soc/mediatek/common/mt6359p.c b/src/soc/mediatek/common/mt6359p.c index de22b3e..e2c8e14 100644 --- a/src/soc/mediatek/common/mt6359p.c +++ b/src/soc/mediatek/common/mt6359p.c @@ -316,12 +316,12 @@
void mt6359p_enable_vpa(bool enable) { - mt6359p_write_field(PMIC_VPA_CON0, !!enable, 0x1, 0); + mt6359p_write_field(PMIC_VPA_CON0, enable, 0x1, 0); }
void mt6359p_enable_vsim1(bool enable) { - mt6359p_write_field(PMIC_VSIM1_CON0, !!enable, 0x1, 0); + mt6359p_write_field(PMIC_VSIM1_CON0, enable, 0x1, 0); }
static void init_pmif_arb(void)