Attention is currently required from: Anand Vaikar, Fred Reitberger, Jason Glenesk.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman: Add Birmanplus board support for PHX1 SOC ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: did you verify that the soc's gpio configuration in gpio.c and the ec's gpio configuration in ec.c are also valid for birmanplus?
File src/mainboard/amd/birman/Kconfig:
https://review.coreboot.org/c/coreboot/+/80353/comment/7bdad66c_8568cb0a : PS2, Line 78: default "3rdparty/blobs/mainboard/amd/birman/EC_birman.bin" do birman and birmanplus share the same ec firmware?
File src/mainboard/amd/birman/variants/birmanplus/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/80353/comment/2a01a5bf_7e91d9e4 : PS2, Line 17: in a few lines the '' in these defines aren't aligned; would be good to make sure that those are all aligned