Hello Martin Roth, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48679
to review the following change.
Change subject: util: pull in Kconfiglib ......................................................................
util: pull in Kconfiglib
Pull in Kconfiglib 14.1 release to the util directory.
Signed-off-by: Jack Rosenthal jrosenth@chromium.org Change-Id: I118562ff5aaaa23501c329e2e4e98dc6d528f546 --- A util/Kconfiglib/.gitignore A util/Kconfiglib/LICENSE.txt A util/Kconfiglib/MANIFEST.in A util/Kconfiglib/README.rst A util/Kconfiglib/alldefconfig.py A util/Kconfiglib/allmodconfig.py A util/Kconfiglib/allnoconfig.py A util/Kconfiglib/allyesconfig.py A util/Kconfiglib/defconfig.py A util/Kconfiglib/examples/Kmenuconfig A util/Kconfiglib/examples/allnoconfig_walk.py A util/Kconfiglib/examples/defconfig_oldconfig.py A util/Kconfiglib/examples/dumpvars.py A util/Kconfiglib/examples/eval_expr.py A util/Kconfiglib/examples/find_symbol.py A util/Kconfiglib/examples/help_grep.py A util/Kconfiglib/examples/kconfiglib.py A util/Kconfiglib/examples/list_undefined.py A util/Kconfiglib/examples/menuconfig_example.py A util/Kconfiglib/examples/merge_config.py A util/Kconfiglib/examples/print_config_tree.py A util/Kconfiglib/examples/print_sym_info.py A util/Kconfiglib/examples/print_tree.py A util/Kconfiglib/genconfig.py A util/Kconfiglib/guiconfig.py A util/Kconfiglib/kconfiglib.py A util/Kconfiglib/listnewconfig.py A util/Kconfiglib/makefile.patch A util/Kconfiglib/menuconfig.py A util/Kconfiglib/oldconfig.py A util/Kconfiglib/olddefconfig.py A util/Kconfiglib/savedefconfig.py A util/Kconfiglib/setconfig.py A util/Kconfiglib/setup.cfg A util/Kconfiglib/setup.py A util/Kconfiglib/tests/Kappend A util/Kconfiglib/tests/Kassignable A util/Kconfiglib/tests/Kchoice A util/Kconfiglib/tests/Kdefconfig_existent A util/Kconfiglib/tests/Kdefconfig_existent_but_n A util/Kconfiglib/tests/Kdefconfig_nonexistent A util/Kconfiglib/tests/Kdefconfig_srctree A util/Kconfiglib/tests/Kdepcopy A util/Kconfiglib/tests/Kdeploop0 A util/Kconfiglib/tests/Kdeploop1 A util/Kconfiglib/tests/Kdeploop10 A util/Kconfiglib/tests/Kdeploop2 A util/Kconfiglib/tests/Kdeploop3 A util/Kconfiglib/tests/Kdeploop4 A util/Kconfiglib/tests/Kdeploop5 A util/Kconfiglib/tests/Kdeploop6 A util/Kconfiglib/tests/Kdeploop7 A util/Kconfiglib/tests/Kdeploop8 A util/Kconfiglib/tests/Kdeploop9 A util/Kconfiglib/tests/Kdirdep A util/Kconfiglib/tests/Kescape A util/Kconfiglib/tests/Keval A util/Kconfiglib/tests/Kexpr_items A util/Kconfiglib/tests/Kheader A util/Kconfiglib/tests/Khelp A util/Kconfiglib/tests/Kifremoval A util/Kconfiglib/tests/Kimply A util/Kconfiglib/tests/Kinclude_path A util/Kconfiglib/tests/Kinclude_path_sourced_1 A util/Kconfiglib/tests/Kinclude_path_sourced_2 A util/Kconfiglib/tests/Kitemlists A util/Kconfiglib/tests/Klocation A util/Kconfiglib/tests/Klocation_sourced A util/Kconfiglib/tests/Kmainmenu A util/Kconfiglib/tests/Kmenuconfig A util/Kconfiglib/tests/Kmisc A util/Kconfiglib/tests/Kmissingrsource A util/Kconfiglib/tests/Kmissingsource A util/Kconfiglib/tests/Korder A util/Kconfiglib/tests/Kpreprocess A util/Kconfiglib/tests/Krange A util/Kconfiglib/tests/Krecursive1 A util/Kconfiglib/tests/Krecursive2 A util/Kconfiglib/tests/Kreferenced A util/Kconfiglib/tests/Krelation A util/Kconfiglib/tests/Krepr A util/Kconfiglib/tests/Kstr A util/Kconfiglib/tests/Kundef A util/Kconfiglib/tests/Kuserfunctions A util/Kconfiglib/tests/Kvisibility A util/Kconfiglib/tests/config_indented A util/Kconfiglib/tests/config_set_bool A util/Kconfiglib/tests/config_set_string A util/Kconfiglib/tests/defconfig_1 A util/Kconfiglib/tests/defconfig_2 A util/Kconfiglib/tests/empty A util/Kconfiglib/tests/kconfigfunctions.py A util/Kconfiglib/tests/reltest A util/Kconfiglib/tests/sub/Kconfig_symlink_2 A util/Kconfiglib/tests/sub/Kconfig_symlink_3 A util/Kconfiglib/tests/sub/Klocation_grsourced1 A util/Kconfiglib/tests/sub/Klocation_grsourced2 A util/Kconfiglib/tests/sub/Klocation_gsourced1 A util/Kconfiglib/tests/sub/Klocation_gsourced2 A util/Kconfiglib/tests/sub/Klocation_rsourced A util/Kconfiglib/tests/sub/defconfig_in_sub A util/Kconfiglib/tests/sub/sub/Kconfig_symlink_1 A util/Kconfiglib/tests/symlink A util/Kconfiglib/testsuite.py M util/README.md 105 files changed, 21,873 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/48679/1
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48679 )
Change subject: util: pull in Kconfiglib ......................................................................
Patch Set 1:
(36 comments)
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst File util/Kconfiglib/README.rst:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 208: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 214: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 327: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 367: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 385: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 405: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 449: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 456: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 461: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 469: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 477: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 485: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 507: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 525: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 539: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 757: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 766: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/README.rst@... PS1, Line 817: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... File util/Kconfiglib/kconfiglib.py:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 777: was created, or the empty string if $srctree wasn't set. This gives nice 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 793: was created, or "CONFIG_" if CONFIG_ wasn't set. This is the prefix used 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 800: KCONFIG_CONFIG_HEADER wasn't set. This string is inserted verbatim at the 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 806: KCONFIG_AUTOHEADER_HEADER wasn't set. This string is inserted verbatim at 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 3253: "wasn't used.", 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/kconfiglib.... PS1, Line 4354: # contraints, it is stored in exactly the same form as 'contraints' may be misspelled - perhaps 'constraints'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/makefile.pa... File util/Kconfiglib/makefile.patch:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/makefile.pa... PS1, Line 15: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/makefile.pa... PS1, Line 46: -- trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/menuconfig.... File util/Kconfiglib/menuconfig.py:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/menuconfig.... PS1, Line 1177: # show-all because the first entry wasn't visible, try turning it off. 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/tests/Kprep... File util/Kconfiglib/tests/Kpreprocess:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/tests/Kprep... PS1, Line 107: $(undefined) trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/tests/Krang... File util/Kconfiglib/tests/Krange:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/tests/Krang... PS1, Line 73: hex "hex range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/tests/Krang... PS1, Line 81: int "int range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... File util/Kconfiglib/testsuite.py:
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... PS1, Line 22: # Like obsessive, for the minimal configuation (defconfig) tests. 'configuation' may be misspelled - perhaps 'configuration'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... PS1, Line 166: "the assigned user value '{}' wasn't reflected in user_value " 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... PS1, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... PS1, Line 514: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/1/util/Kconfiglib/testsuite.p... PS1, Line 2731: # Runs tests on configurations from the kernel. Tests compability with the 'compability' may be misspelled - perhaps 'compatibility'?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48679 )
Change subject: util: pull in Kconfiglib ......................................................................
Patch Set 2:
(36 comments)
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst File util/Kconfiglib/README.rst:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 208: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 214: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 327: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 367: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 385: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 405: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 449: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 456: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 461: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 469: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 477: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 485: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 507: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 525: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 539: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 757: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 766: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/README.rst@... PS2, Line 817: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... File util/Kconfiglib/kconfiglib.py:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 777: was created, or the empty string if $srctree wasn't set. This gives nice 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 793: was created, or "CONFIG_" if CONFIG_ wasn't set. This is the prefix used 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 800: KCONFIG_CONFIG_HEADER wasn't set. This string is inserted verbatim at the 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 806: KCONFIG_AUTOHEADER_HEADER wasn't set. This string is inserted verbatim at 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 3253: "wasn't used.", 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/kconfiglib.... PS2, Line 4354: # contraints, it is stored in exactly the same form as 'contraints' may be misspelled - perhaps 'constraints'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/makefile.pa... File util/Kconfiglib/makefile.patch:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/makefile.pa... PS2, Line 15: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/makefile.pa... PS2, Line 46: -- trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/menuconfig.... File util/Kconfiglib/menuconfig.py:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/menuconfig.... PS2, Line 1177: # show-all because the first entry wasn't visible, try turning it off. 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/tests/Kprep... File util/Kconfiglib/tests/Kpreprocess:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/tests/Kprep... PS2, Line 107: $(undefined) trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/tests/Krang... File util/Kconfiglib/tests/Krange:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/tests/Krang... PS2, Line 73: hex "hex range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/tests/Krang... PS2, Line 81: int "int range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... File util/Kconfiglib/testsuite.py:
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... PS2, Line 22: # Like obsessive, for the minimal configuation (defconfig) tests. 'configuation' may be misspelled - perhaps 'configuration'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... PS2, Line 166: "the assigned user value '{}' wasn't reflected in user_value " 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... PS2, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... PS2, Line 514: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/2/util/Kconfiglib/testsuite.p... PS2, Line 2731: # Runs tests on configurations from the kernel. Tests compability with the 'compability' may be misspelled - perhaps 'compatibility'?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48679 )
Change subject: util: pull in Kconfiglib ......................................................................
Patch Set 3:
(36 comments)
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst File util/Kconfiglib/README.rst:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 208: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 214: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 327: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 367: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 385: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 405: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 449: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 456: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 461: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 469: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 477: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 485: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 507: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 525: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 539: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 757: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 766: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/README.rst@... PS3, Line 817: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... File util/Kconfiglib/kconfiglib.py:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 777: was created, or the empty string if $srctree wasn't set. This gives nice 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 793: was created, or "CONFIG_" if CONFIG_ wasn't set. This is the prefix used 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 800: KCONFIG_CONFIG_HEADER wasn't set. This string is inserted verbatim at the 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 806: KCONFIG_AUTOHEADER_HEADER wasn't set. This string is inserted verbatim at 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 3253: "wasn't used.", 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/kconfiglib.... PS3, Line 4354: # contraints, it is stored in exactly the same form as 'contraints' may be misspelled - perhaps 'constraints'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/makefile.pa... File util/Kconfiglib/makefile.patch:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/makefile.pa... PS3, Line 15: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/makefile.pa... PS3, Line 46: -- trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/menuconfig.... File util/Kconfiglib/menuconfig.py:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/menuconfig.... PS3, Line 1177: # show-all because the first entry wasn't visible, try turning it off. 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/tests/Kprep... File util/Kconfiglib/tests/Kpreprocess:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/tests/Kprep... PS3, Line 107: $(undefined) trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/tests/Krang... File util/Kconfiglib/tests/Krange:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/tests/Krang... PS3, Line 73: hex "hex range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/tests/Krang... PS3, Line 81: int "int range 10-20" trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... File util/Kconfiglib/testsuite.py:
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... PS3, Line 22: # Like obsessive, for the minimal configuation (defconfig) tests. 'configuation' may be misspelled - perhaps 'configuration'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... PS3, Line 166: "the assigned user value '{}' wasn't reflected in user_value " 'wasn' may be misspelled - perhaps 'was'?
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... PS3, Line 512: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... PS3, Line 514: trailing whitespace
https://review.coreboot.org/c/coreboot/+/48679/3/util/Kconfiglib/testsuite.p... PS3, Line 2731: # Runs tests on configurations from the kernel. Tests compability with the 'compability' may be misspelled - perhaps 'compatibility'?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48679 )
Change subject: util: pull in Kconfiglib ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: hrm. python :-(
Jack Rosenthal has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48679 )
Change subject: util: pull in Kconfiglib ......................................................................
Abandoned
revisit later