Attention is currently required from: Jeremy Soller, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56256 )
Change subject: src/soc/intel/*: Change legacy_8254_timer to CMOS option
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/skylake/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123951):
https://review.coreboot.org/c/coreboot/+/56256/comment/5a0301d9_a8181b97
PS6, Line 346: const unsigned int legacy_8254_timer = get_uint_option("legacy_8254_timer", CONFIG(USE_LEGACY_8254_TIMER));
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic82c7f25cdf6587de5c40f59441579cfc92ff2f1
Gerrit-Change-Number: 56256
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 13:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment