Attention is currently required from: Paul Menzel, Angel Pons, Krystian Hebel.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 )
Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
......................................................................
Patch Set 12:
(1 comment)
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/9cfffa79_de7dc5cf
PS11, Line 11: /* Add 3 more bytes (2 for possible CRLF) and third for NULL char */
Parentheses seems misplaced, how about […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf
Gerrit-Change-Number: 64639
Gerrit-PatchSet: 12
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 10:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment