Attention is currently required from: Alexander Couzens, Felix Singer.
Nicolas Provost has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75992?usp=email )
Change subject: new port for Lenovo L420 laptop ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75992/comment/b2385695_7d5416da : PS7, Line 7: new port for Lenovo L420 laptop
Suggestion: […]
Done
File src/mainboard/lenovo/l420/Kconfig:
https://review.coreboot.org/c/coreboot/+/75992/comment/f342d08b_6d7677bc : PS7, Line 17: select TPM
This should probably be `MAINBOARD_HAS_TPM1`. Then it compiles without errors.
Done
https://review.coreboot.org/c/coreboot/+/75992/comment/bf59dde6_0e060365 : PS7, Line 5: select SYSTEM_TYPE_LAPTOP : select NORTHBRIDGE_INTEL_SANDYBRIDGE : select USE_NATIVE_RAMINIT : select SOUTHBRIDGE_INTEL_BD82X6X : select EC_QUANTA_IT8518 : select NO_UART_ON_SUPERIO : select BOARD_ROMSIZE_KB_4096 : select HAVE_ACPI_TABLES : select HAVE_OPTION_TABLE : select HAVE_CMOS_DEFAULT : select HAVE_ACPI_RESUME : select INTEL_INT15 : select TPM : select MEMORY_MAPPED_TPM : select MAINBOARD_HAS_LIBGFXINIT : select GFX_GMA_PANEL_1_ON_LVDS : select INTEL_GMA_HAVE_VBT : select SERIRQ_CONTINUOUS_MODE : s
Please order the list alphabetically: […]
Done
File src/mainboard/lenovo/l420/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75992/comment/226a3a7c_8776587e : PS7, Line 68: # Enable SATA ports 0 (HDD bay) & 1 (ODD bay) & 2 (mSATA) & : # 3 (eSATA) & 4 (dock) : register "sata_port_map" = "0x1f" : : # Set max SATA speed to 6.0 Gb/s :
Move these under the SATA controller
Done
-
Nicolas Provost (Code Review)