Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83474?usp=email )
Change subject: payloads/edk2/Makefile: Add $(EDK2_PATH) as dependency for 'gop_driver' target ......................................................................
payloads/edk2/Makefile: Add $(EDK2_PATH) as dependency for 'gop_driver' target
Without this, when doing a clean build with 'make j$(nproc)`, the build can fail copying the GOP driver file since the target directory does not exist yet.
TEST=build/boot google/hatch (akemi) w/edk2 payload and GOP driver init on a clean git checkout.
Change-Id: Ic510d70041dc099e6bc469528b80d1e271976655 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83474 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Sean Rhodes sean@starlabs.systems --- M payloads/external/edk2/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Sean Rhodes: Looks good to me, approved
diff --git a/payloads/external/edk2/Makefile b/payloads/external/edk2/Makefile index ef3327e..3966b91 100644 --- a/payloads/external/edk2/Makefile +++ b/payloads/external/edk2/Makefile @@ -222,7 +222,7 @@ BMP3:$(EDK2_PATH)/MdeModulePkg/Logo/Logo.bmp;; \ esac \
-gop_driver: +gop_driver: $(EDK2_PATH) if [ -n "$(CONFIG_EDK2_GOP_DRIVER)" ]; then \ echo "Using GOP driver $(CONFIG_EDK2_GOP_FILE)"; \ cp $(top)/$(CONFIG_EDK2_GOP_FILE) $(EDK2_PATH)/UefiPayloadPkg/IntelGopDriver.efi; \