Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76028?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortEdp dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortEdp dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortEdp" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I24b0f738ed2cf336ee3e5f97a9eed1680caaff02 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/puff/variants/baseboard/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb M src/mainboard/protectli/vault_cml/devicetree.cb 8 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/76028/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 6d58615..ab42668 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -53,7 +53,7 @@ register "SlowSlewRateForSa" = "0" register "SlowSlewRateForFivr" = "2" # Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index f647e7e..184860fd 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -37,7 +37,7 @@ }" register Device4Enable = true # Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb index 2672909..66a6d31 100644 --- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb @@ -37,7 +37,7 @@ }" register Device4Enable = true # Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 52a9c4a..1acfb20 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -42,7 +42,7 @@ register "SlowSlewRateForSa" = "0" register "SlowSlewRateForFivr" = "2" # Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 32220d3..1af241c 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -45,7 +45,7 @@ }" register Device4Enable = true # Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index 60725af..e31413a 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -3,7 +3,7 @@ device cpu_cluster 0 on end
# Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index 3d78bbb..1891786 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -3,7 +3,7 @@ device cpu_cluster 0 on end
# Enable eDP device - register "DdiPortEdp" = "1" + register DdiPortEdp = true # Enable HPD for DDI ports B/C/D/F register "DdiPortBHpd" = "1" register "DdiPortCHpd" = "1" diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb index 13d2ca0..44455b2 100644 --- a/src/mainboard/protectli/vault_cml/devicetree.cb +++ b/src/mainboard/protectli/vault_cml/devicetree.cb @@ -20,7 +20,7 @@ register ScsEmmcHs400Enabled = true
# Enable eDP device - register "DdiPortEdp" = "1" # Display Port + register DdiPortEdp = true # Display Port
# Enable HPD for DDI ports B/C register "DdiPortBHpd" = "1" # HDMI