Attention is currently required from: Andrey Pronin, Paul Menzel, Christian Walter, Yi Chou.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 )
Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ......................................................................
Patch Set 6:
(3 comments)
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/3c13cc25_b0d205d7 PS6, Line 504: case TPM_RC_HANDLE: Use `__attribute__((__fallthrough__))`, or `__fallthrough` defined in src/commonlib/bsd/include/commonlib/bsd/compiler.h.
https://review.coreboot.org/c/coreboot/+/71885/comment/8c50ab0d_84879ec0 PS6, Line 505: ( No need for parentheses I think
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/ded6ca63_c8d9a381 PS2, Line 550: "%s:%d - " : "size mismatch: expected %d, remaining %zd\n",
Done
You modified the wrong function.
-
Yu-Ping Wu (Code Review)