Attention is currently required from: Jonathan Zhang, Stefan Reinauer, David Hendricks, Subrata Banik, Angel Pons, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54510 )
Change subject: device/device_util: add dev_find_dsn()
......................................................................
Patch Set 8:
(1 comment)
File src/device/device_util.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162336):
https://review.coreboot.org/c/coreboot/+/54510/comment/ab93b02b_c424adbe
PS8, Line 84: * @param serial Serial number of the device.
Possible repeated word: 'serial'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54b6dc42c8da47cd7b4447ab23a6a21562c7618b
Gerrit-Change-Number: 54510
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 03:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment