Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Subrata Banik, Wonkyu Kim.
Pratikkumar V Prajapati has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )
Change subject: src/device: Add more condition to check valid PCI device id
......................................................................
Patch Set 2:
(1 comment)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/84228/comment/f6a5406f_1faf5ecb?usp... :
PS2, Line 1225: dummy.vendor = id & 0xffff;
: dummy.device = (id >> 16) & 0xffff;
: if ((dummy.vendor == 0x0000) || (dummy.vendor == 0xffff) ||
: (dummy.device == 0x0000) || (dummy.device == 0xffff)) {
: printk(BIOS_SPEW, "device %s [0x%04x/0x%04x] is not found.\n",
: dev_path(&dummy), dummy.vendor, dummy.device);
:
why don't u make an inline function, as this test is used at multiple places?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84228?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffabc9037a8af1b2a4ffebdf30199c4f6eae9540
Gerrit-Change-Number: 84228
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Sat, 07 Sep 2024 04:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No