[M] Change in coreboot[master]: mb/amd/birman/devicetree_phoenix: update USB PHY settings

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75823?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/amd/birman/devicetree_phoenix: update USB PHY settings
......................................................................

mb/amd/birman/devicetree_phoenix: update USB PHY settings

Update the initial USB PHY tuning values that were a copy of the ones
from the Chausie mainboard to the values used in the Birman UEFI
firmware reference implementation. The USB3 PHY tuning values are still
the same while some of the USB2 PHY tuning values are different. The
last two USB2 PHYs that are used by the USB4 controllers have a
different parameter set compared to the other USB2 PHYs.

TEST=All USB ports on Birman function as expected.

Signed-off-by: Felix Held 
Change-Id: I0ddfa2594d66b21582282ab8509c921a6e81a93f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75823
Reviewed-by: Fred Reitberger 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/amd/birman/devicetree_phoenix.cb
1 file changed, 40 insertions(+), 40 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Fred Reitberger: Looks good to me, approved

diff --git a/src/mainboard/amd/birman/devicetree_phoenix.cb b/src/mainboard/amd/birman/devicetree_phoenix.cb
index 6cbb36f..6894764 100644
--- a/src/mainboard/amd/birman/devicetree_phoenix.cb
+++ b/src/mainboard/amd/birman/devicetree_phoenix.cb
@@ -44,13 +44,13 @@
    register "usb_phy_custom" = "1"
    register "usb_phy" = "{
    	.Usb2PhyPort[0] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -58,13 +58,13 @@
    		.txrestune = 0x2,
    	},
    	.Usb2PhyPort[1] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -72,13 +72,13 @@
    		.txrestune = 0x2,
    	},
    	.Usb2PhyPort[2] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -86,13 +86,13 @@
    		.txrestune = 0x2,
    	},
    	.Usb2PhyPort[3] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -100,13 +100,13 @@
    		.txrestune = 0x2,
    	},
    	.Usb2PhyPort[4] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -114,13 +114,13 @@
    		.txrestune = 0x2,
    	},
    	.Usb2PhyPort[5] = {
-			.compdistune = 0x3,
+			.compdistune = 0x1,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
    		.txvreftune = 0x3,
@@ -131,13 +131,13 @@
    		.compdistune = 0x3,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
-			.txvreftune = 0x3,
+			.txvreftune = 0x6,
    		.txhsxvtune = 0x3,
    		.txrestune = 0x2,
    	},
@@ -145,13 +145,13 @@
    		.compdistune = 0x3,
    		.pllbtune = 0x1,
    		.pllitune = 0x0,
-			.pllptune = 0xe,
-			.sqrxtune = 0x3,
-			.txfslstune = 0x3,
-			.txpreempamptune = 0x2,
+			.pllptune = 0xc,
+			.sqrxtune = 0x2,
+			.txfslstune = 0x1,
+			.txpreempamptune = 0x3,
    		.txpreemppulsetune = 0x0,
    		.txrisetune = 0x1,
-			.txvreftune = 0x3,
+			.txvreftune = 0x6,
    		.txhsxvtune = 0x3,
    		.txrestune = 0x2,
    	},