Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57023 )
Change subject: WIP: Herobrine: Fix board id GPIOs ......................................................................
WIP: Herobrine: Fix board id GPIOs
Board IDs did not correspond to the ones in the herobrine schematic and also returned incorrect values. Correcting so they match the schematic and also tested so that they returned 0, which is what is expected.
Signed-off-by: Shelley Chen shchen@google.com Change-Id: Idef54591610f4328a88f38e92113e047ffd2f0b7 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/57023/1
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index 2f7ad03..e92d1ef9c 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -12,7 +12,7 @@ uint32_t board_id(void) { static uint32_t id = UNDEFINED_STRAPPING_ID; - const gpio_t pins[] = {[2] = GPIO(50), [1] = GPIO(49), [0] = GPIO(48)}; + const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)};
if (id == UNDEFINED_STRAPPING_ID) id = gpio_pulldown_base2_value(pins, ARRAY_SIZE(pins));