Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25362
Change subject: soc/intel/skylake: Do a heci_reset before reading ME firmware version ......................................................................
soc/intel/skylake: Do a heci_reset before reading ME firmware version
This change adds a call to heci_reset before attempting to read ME firmware version. This is important to ensure that both ME and BIOS are in sync.
BUG=b:76167737 BRANCH=poppy TEST=Verfied that ME firmware version read does not fail on first boot after power failure (i.e. removing battery and AC power).
Change-Id: Ib6b39c398d2e1177b087352a4acb8bcf5a9897d6 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/skylake/me.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/25362/1
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index 67d7bc0..9a721bc 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -254,6 +254,12 @@ (hfs.fields.operation_mode != ME_HFS_MODE_NORMAL)) goto failed;
+ /* + * It is important to do a heci_reset to ensure BIOS and ME are in sync + * before reading firmware version. + */ + heci_reset(); + if (!heci_send(&fw_ver_msg, sizeof(fw_ver_msg), BIOS_HOST_ADD, HECI_MKHI_ADD)) goto failed;