Attention is currently required from: Elyes Haouas, Jianeng Ceng, Paul Menzel, Subrata Banik.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 23:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/147e519e_1d550de4 :
PS9, Line 9: Add RT5645 AMP support.
The reason is the newly added pin not support in generic I2C driver. […]
Pual,
yep, it's smiliar to rt5663, but the rt5663 is very old and it was used the hard code like `RT53` or `10EC5663`, there are so much old device used it and no longer updates in recent years, we don't wanna change it and make something others trouble for that.
on the others side, rt5663 and RT5645/5650 are the different series, it may caused some ambiguity. And if we change that to the common driver, the name should like `RT56XX`, it may cause some confusion on DT too.
because I2C generic driver dose not support dsd gpio setting, we declared the new rt5645 series driver for expansion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 23
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 18 Apr 2024 07:21:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-MessageType: comment