Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50171 )
Change subject: src: Remove unused <cpu/x86/smm.h> ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/intel/broadwell/pch/acpi.c:
https://review.coreboot.org/c/coreboot/+/50171/comment/00b5617f_ac019817 PS1, Line 3: #include <acpi/acpi.h> : #include <acpi/acpigen.h> : #include <arch/ioapic.h> : #include <arch/smp/mpspec.h> : #include <cbmem.h> : #include <device/pci_ops.h> : #include <cpu/x86/smm.h> : #include <console/console.h> : #include <types.h> : #include <string.h> : #include <arch/cpu.h> : #include <cpu/x86/msr.h> : #include <cpu/intel/turbo.h> : #include <soc/acpi.h> : #include <soc/iomap.h> : #include <soc/lpc.h> : #include <soc/pci_devs.h> : #include <soc/pm.h> : #include <soc/systemagent.h> : #include <soc/intel/broadwell/chip.h>
There is more includes than code lines 😄
I will get rid of this file with CB:46888 and CB:46889