Change in coreboot[master]: drivers/pcie/generic: Add support to generate code under companion de...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 )

Change subject: drivers/pcie/generic: Add support to generate code under companion device instead
......................................................................

Patch Set 9:

(2 comments)

Patchset:

PS5:
> I'm all ears, but that's what we have at the moment 😐

Technically we don't have proper support for device drivers in sconfig. What
we do all the time is to repurpose the chip drivers. We could add support for
device drivers, i.e. sconfig syntax to attach specific device-ops and config
structs like we have for chip drivers. However for this particular case, we'd
have to make it a list of device-ops, I guess¹ (a little overhead and a lot
more implementation effort). Having the sconfig syntax would solve other
issues too, though. For instance, the singleton PCI ID lists for SoC-integrated
devices that are becoming more and more controversial would become obsolete.

¹ I'm not sure why there is an additional device in the devicetree. Is it
just to have something for the chip-driver semantics?

File src/drivers/pcie/generic/generic.c:

https://review.coreboot.org/c/coreboot/+/62301/comment/9c1f2a01_5a8da3e5 
PS9, Line 36: present
Not sure, was this meant to be `parent`?