Attention is currently required from: Lance Zhao, Kevin Chiu.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51707 )
Change subject: acpi: Add variant hook to update device status
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/51707/comment/3428a876_536fb838
PS1, Line 193: __weak
This is not really required. What you need to do is set the device to on/off instead of changing acpi_device_status. I will post a comment on follow-up CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cca84a974207fff7f60f5da1ddb8a07ab63a698
Gerrit-Change-Number: 51707
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Comment-Date: Tue, 23 Mar 2021 03:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment