Change in coreboot[master]: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller

Change-Id: If4886591b7d73293773e4d36ec653ef42e8b2f54
Signed-off-by: Felix Held 
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44679/1

diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
index c1766e8..99c2c6d 100644
--- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
@@ -58,7 +58,7 @@
    /** Offset 0x00C8**/	uint32_t                    tseg_size;
    /** Offset 0x00CC**/	uint8_t                     pspp_policy;
    /** Offset 0x00CD**/	uint8_t                     audio_soundwire;
-	/** Offset 0x00CE**/	uint8_t                     unused8;
+	/** Offset 0x00CE**/	uint8_t                     hd_audio_enable;
    /** Offset 0x00CF**/	uint8_t                     unused9;
    /** Offset 0x00D0**/	uint32_t                    bert_size;
    /** Offset 0x00D4**/	uint8_t                     UnusedUpdSpace0;

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44679/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44679/1//COMMIT_MSG@8 
PS1, Line 8: 
Can you please add corresponding CL in picasso FSP that adds this UPD as Cq-Depend?

Also, please use:
BUG=b:???
BRANCH=zork

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Hello build bot (Jenkins), Raul Rangel, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44679

to look at the new patch set (#2).

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller

BUG=b:158535201,b:162302028
BRANCH=zork

Change-Id: If4886591b7d73293773e4d36ec653ef42e8b2f54
Signed-off-by: Felix Held 
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44679/2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44679/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44679/1//COMMIT_MSG@8 
PS1, Line 8:
> Can you please add corresponding CL in picasso FSP that adds this UPD as Cq-Depend? […]

Done

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44679 )

Change subject: vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller
......................................................................

vc/amd/fsp/picasso: add FSP-M UPD to disable the HD Audio controller

BUG=b:158535201,b:162302028
BRANCH=zork

Change-Id: If4886591b7d73293773e4d36ec653ef42e8b2f54
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44679
Reviewed-by: Raul Rangel 
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Raul Rangel: Looks good to me, approved

diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
index c1766e8..99c2c6d 100644
--- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h
@@ -58,7 +58,7 @@
    /** Offset 0x00C8**/	uint32_t                    tseg_size;
    /** Offset 0x00CC**/	uint8_t                     pspp_policy;
    /** Offset 0x00CD**/	uint8_t                     audio_soundwire;
-	/** Offset 0x00CE**/	uint8_t                     unused8;
+	/** Offset 0x00CE**/	uint8_t                     hd_audio_enable;
    /** Offset 0x00CF**/	uint8_t                     unused9;
    /** Offset 0x00D0**/	uint32_t                    bert_size;
    /** Offset 0x00D4**/	uint8_t                     UnusedUpdSpace0;