Change in coreboot[master]: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nippe...
Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Eric Peers, Karthik Ramasubramanian. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/d378add4_18c2c402 PS4, Line 70: PAD_NC(GPIO_31),
Guybrush reference board v2 still uses GPIO_31 for EN_SPKR. So this needs to be overridden there.
Hi Rob, per the suggestion from Karthik, I'll add GPIO_31 override in guybrush variant, thanks.
https://review.coreboot.org/c/coreboot/+/59051/comment/f0995530_cc686f8e PS4, Line 87: PAD_NC(GPIO_70),
Please configure the following GPIOs in the baseboard here. […]
Done
-
Kevin Chiu (Code Review)