Change in coreboot[master]: soc/intel/baytrail/Makefile.inc: Sort entries

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34463 )

Change subject: soc/intel/baytrail/Makefile.inc: Sort entries
......................................................................

soc/intel/baytrail/Makefile.inc: Sort entries

Change-Id: Ic35a901c8272928a0389b38a74f4eac74977a080
Signed-off-by: Angel Pons 
---
M src/soc/intel/baytrail/Makefile.inc
1 file changed, 44 insertions(+), 39 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34463/1

diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.inc
index 6e6eb9c..4c61e1c8 100644
--- a/src/soc/intel/baytrail/Makefile.inc
+++ b/src/soc/intel/baytrail/Makefile.inc
@@ -9,50 +9,55 @@
 subdirs-y += ../../../cpu/intel/turbo
 subdirs-y += ../../../cpu/intel/common

-ramstage-y += memmap.c
-romstage-y += memmap.c
-postcar-y += memmap.c
-ramstage-y += tsc_freq.c
-romstage-y += tsc_freq.c
-postcar-y += tsc_freq.c
-smm-y += tsc_freq.c
-romstage-y += spi.c
-postcar-y += spi.c
-ramstage-y += spi.c
-smm-y += spi.c
-ramstage-y += chip.c
-ramstage-y += gfx.c
-ramstage-y += iosf.c
 romstage-y += iosf.c
-smm-y += iosf.c
-postcar-y += iosf.c
-ramstage-y += northcluster.c
-ramstage-y += ramstage.c
-ramstage-y += gpio.c
-ramstage-y += cpu.c
+romstage-y += memmap.c
 romstage-y += pmutil.c
+romstage-y += spi.c
+romstage-y += stage_cache.c
+romstage-y += tsc_freq.c
+
+postcar-y += iosf.c
+postcar-y += memmap.c
+postcar-y += spi.c
+postcar-y += tsc_freq.c
+
+ramstage-y += acpi.c
+ramstage-y += chip.c
+ramstage-y += cpu.c
+ramstage-y += dptf.c
+ramstage-y += ehci.c
+ramstage-y += emmc.c
+ramstage-y += gfx.c
+ramstage-y += gpio.c
+ramstage-y += hda.c
+ramstage-y += iosf.c
+ramstage-y += lpe.c
+ramstage-y += lpss.c
+ramstage-y += memmap.c
+ramstage-y += northcluster.c
+ramstage-y += pcie.c
+ramstage-y += perf_power.c
 ramstage-y += pmutil.c
+ramstage-y += ramstage.c
+ramstage-y += sata.c
+ramstage-y += scc.c
+ramstage-y += sd.c
+ramstage-y += smm.c
+ramstage-y += southcluster.c
+ramstage-y += spi.c
+ramstage-y += stage_cache.c
+ramstage-y += tsc_freq.c
+ramstage-y += xhci.c
+ramstage-$(CONFIG_ELOG) += elog.c
+ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c
+
+# smm
+smm-y += iosf.c
 smm-y += pmutil.c
 smm-y += smihandler.c
-ramstage-y += smm.c
-ramstage-y += ehci.c
-ramstage-y += xhci.c
-ramstage-y += southcluster.c
-ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c
-ramstage-y += sata.c
-ramstage-y += acpi.c
-ramstage-y += lpe.c
-ramstage-y += scc.c
-ramstage-y += emmc.c
-ramstage-y += lpss.c
-ramstage-y += pcie.c
-ramstage-y += sd.c
-ramstage-y += dptf.c
-ramstage-y += perf_power.c
-ramstage-y += stage_cache.c
-romstage-y += stage_cache.c
-ramstage-$(CONFIG_ELOG) += elog.c
-ramstage-y += hda.c
+smm-y += spi.c
+smm-y += tsc_freq.c
+

# Remove as ramstage gets fleshed out
 ramstage-y += placeholders.c

[Angel Pons (Code Review)]

Hello Patrick Rudolph, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34463

to look at the new patch set (#2).

Change subject: soc/intel/baytrail/Makefile.inc: Sort entries
......................................................................

soc/intel/baytrail/Makefile.inc: Sort entries

Change-Id: Ic35a901c8272928a0389b38a74f4eac74977a080
Signed-off-by: Angel Pons 
---
M src/soc/intel/baytrail/Makefile.inc
1 file changed, 42 insertions(+), 39 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34463/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34463 )

Change subject: soc/intel/baytrail/Makefile.inc: Sort entries
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34463 )

Change subject: soc/intel/baytrail/Makefile.inc: Sort entries
......................................................................

Patch Set 2: Code-Review+1

Is that common in other components/sub-directories?

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34463 )

Change subject: soc/intel/baytrail/Makefile.inc: Sort entries
......................................................................

soc/intel/baytrail/Makefile.inc: Sort entries

Change-Id: Ic35a901c8272928a0389b38a74f4eac74977a080
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34463
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Paul Menzel 
---
M src/soc/intel/baytrail/Makefile.inc
1 file changed, 42 insertions(+), 39 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.inc
index 6e6eb9c..3ad6a8f 100644
--- a/src/soc/intel/baytrail/Makefile.inc
+++ b/src/soc/intel/baytrail/Makefile.inc
@@ -9,50 +9,53 @@
 subdirs-y += ../../../cpu/intel/turbo
 subdirs-y += ../../../cpu/intel/common

-ramstage-y += memmap.c
-romstage-y += memmap.c
-postcar-y += memmap.c
-ramstage-y += tsc_freq.c
-romstage-y += tsc_freq.c
-postcar-y += tsc_freq.c
-smm-y += tsc_freq.c
-romstage-y += spi.c
-postcar-y += spi.c
-ramstage-y += spi.c
-smm-y += spi.c
-ramstage-y += chip.c
-ramstage-y += gfx.c
-ramstage-y += iosf.c
 romstage-y += iosf.c
-smm-y += iosf.c
-postcar-y += iosf.c
-ramstage-y += northcluster.c
-ramstage-y += ramstage.c
-ramstage-y += gpio.c
-ramstage-y += cpu.c
+romstage-y += memmap.c
 romstage-y += pmutil.c
+romstage-y += spi.c
+romstage-y += stage_cache.c
+romstage-y += tsc_freq.c
+
+postcar-y += iosf.c
+postcar-y += memmap.c
+postcar-y += spi.c
+postcar-y += tsc_freq.c
+
+ramstage-y += acpi.c
+ramstage-y += chip.c
+ramstage-y += cpu.c
+ramstage-y += dptf.c
+ramstage-y += ehci.c
+ramstage-y += emmc.c
+ramstage-y += gfx.c
+ramstage-y += gpio.c
+ramstage-y += hda.c
+ramstage-y += iosf.c
+ramstage-y += lpe.c
+ramstage-y += lpss.c
+ramstage-y += memmap.c
+ramstage-y += northcluster.c
+ramstage-y += pcie.c
+ramstage-y += perf_power.c
 ramstage-y += pmutil.c
+ramstage-y += ramstage.c
+ramstage-y += sata.c
+ramstage-y += scc.c
+ramstage-y += sd.c
+ramstage-y += smm.c
+ramstage-y += southcluster.c
+ramstage-y += spi.c
+ramstage-y += stage_cache.c
+ramstage-y += tsc_freq.c
+ramstage-y += xhci.c
+ramstage-$(CONFIG_ELOG) += elog.c
+ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c
+
+smm-y += iosf.c
 smm-y += pmutil.c
 smm-y += smihandler.c
-ramstage-y += smm.c
-ramstage-y += ehci.c
-ramstage-y += xhci.c
-ramstage-y += southcluster.c
-ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c
-ramstage-y += sata.c
-ramstage-y += acpi.c
-ramstage-y += lpe.c
-ramstage-y += scc.c
-ramstage-y += emmc.c
-ramstage-y += lpss.c
-ramstage-y += pcie.c
-ramstage-y += sd.c
-ramstage-y += dptf.c
-ramstage-y += perf_power.c
-ramstage-y += stage_cache.c
-romstage-y += stage_cache.c
-ramstage-$(CONFIG_ELOG) += elog.c
-ramstage-y += hda.c
+smm-y += spi.c
+smm-y += tsc_freq.c

# Remove as ramstage gets fleshed out
 ramstage-y += placeholders.c