[S] Change in coreboot[main]: mb/google/brox/var/lotso: Add FW_CONFIG for FP - coreboot-gerrit

9 Jul 2024


      Attention is currently required from: Eric Lai, Jian Tong, Shelley Chen, Subrata Banik, Wentao Qin.
Karthik Ramasubramanian has posted comments on this change by Wentao Qin. ( https://review.coreboot.org/c/coreboot/+/83388?usp=email )
Change subject: mb/google/brox/var/lotso: Add FW_CONFIG for FP
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83388/comment/feb3e82e_61e033b7?usp... :
PS2, Line 30: option FP_PRESENT		0
This bit config value seems counter intuitive - 0 for present/enabled and 1 for absent/disabled. Is that intentional?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83388?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ee5fcd1c29099bdbee741ef76c00cf45fcc1189
Gerrit-Change-Number: 83388
Gerrit-PatchSet: 2
Gerrit-Owner: Wentao Qin qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Jian Tong tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jinfang Mao maojinfang@huaqin.corp-partner.google.com
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jian Tong tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Wentao Qin qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 09 Jul 2024 15:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No