Attention is currently required from: Paul Menzel, Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 )
Change subject: arch/x86/smbios: Fix file formatting ......................................................................
Patch Set 4:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74170/comment/9553d149_b9b0469c PS2, Line 378: : t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED : | BIOS_CHARACTERISTICS_SELECTABLE_BOOT : | BIOS_CHARACTERISTICS_UPGRADEABLE;
Yes, but it was the result of the `.clang-format` file. […]
Fix in the new changes
https://review.coreboot.org/c/coreboot/+/74170/comment/72586f8a_e80eec0e PS2, Line 1276: || device_type == SMBIOS_DEVICE_TYPE_UNKNOWN)
What exactly is fixed here? Both conditions were nicely aligned before.
Fixed in the new changes.
-
Utkarsh Verma (Code Review)