Attention is currently required from: Hung-Te Lin, Jarried Lin.
Dehui Sun has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................
Patch Set 13:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85362/comment/f8239ad2_8512f8ad?usp... :
PS12, Line 8:
Yes, I found a Web site for CI-700. Still, you should add a paragraph about the device. […]
Yes, we have made some modifications to the commit message.
https://review.coreboot.org/c/coreboot/+/85362/comment/4ddc6d01_e11a7282?usp... :
PS12, Line 20: [booker_init] AP hash rule: 0xbe00.
How can I decode the value?
This value is the default register's value for hardware design logic and will determine a hash function. So we don't need to decode it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6bde1e20137890addf18b23b47f17b1f63824b22
Gerrit-Change-Number: 85362
Gerrit-PatchSet: 13
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 06 Dec 2024 09:40:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com