Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60980 )
Change subject: mb/starlabs/lite: Add StarLite Mk III ......................................................................
Patch Set 45:
(3 comments)
This change is ready for review.
File src/mainboard/starlabs/lite/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60980/comment/b5a19ccc_9ae73cb8 PS28, Line 8: enum cmos_power_profile get_power_profile(enum cmos_power_profile fallback) : { : const unsigned int power_profile = get_uint_option("power_profile", fallback); : return power_profile < NUM_POWER_PROFILES ? power_profile : fallback; : }
I think you put it there :) I'll make another patch to move the one in mb/labtop too
Done
File src/mainboard/starlabs/lite/smbios.c:
https://review.coreboot.org/c/coreboot/+/60980/comment/c69957b2_0c93f07e PS28, Line 20: /* Get the Embedded Controller firmware version */ : void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) : { : u16 ec_version = it_get_version(); : : *ec_major_revision = ec_version >> 8; : *ec_minor_revision = ec_version & 0xff; : }
Will make a separate patch
Done
File src/mainboard/starlabs/lite/variants/glk/romstage.c:
https://review.coreboot.org/c/coreboot/+/60980/comment/736b2b19_bb267fe9 PS28, Line 59: config->DDR3LPageSize = 0x01, : config->DDR3LASR = 0x00,
Does this matter if you're using LPDDR?
Pretty sure it doesn't - but having them specified covers hardcoded UPDs.