Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47709 )
Change subject: src/cpu: Remove unused symbols ......................................................................
src/cpu: Remove unused symbols
Remove the unused Kconfig symbol CPU_MICROCODE_MULTIPLE_FILES.
Change-Id: I18115e07694658a2f77c447d3ab5c899c1bdcc61 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/Kconfig M src/cpu/Makefile.inc 2 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47709/1
diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig index 933e50f..297b1a1 100644 --- a/src/cpu/Kconfig +++ b/src/cpu/Kconfig @@ -111,7 +111,6 @@ config CPU_MICROCODE_CBFS_EXTERNAL_BINS bool "Include external microcode binary" select USE_CPU_MICROCODE_CBFS_BINS - depends on !CPU_MICROCODE_MULTIPLE_FILES help Select this option if you want to include external binary files in the CPUs native format. They will be included as a separate @@ -128,7 +127,6 @@
config CPU_MICROCODE_CBFS_EXTERNAL_HEADER bool "Include external microcode header files" - depends on !CPU_MICROCODE_MULTIPLE_FILES help Select this option if you want to include external c header files containing the CPU microcode. This will be included as a separate @@ -179,12 +177,6 @@
endchoice
-config CPU_MICROCODE_MULTIPLE_FILES - bool - help - Select this option to install separate microcode container files into - CBFS instead of using the traditional monolithic microcode file format. - config CPU_MICROCODE_HEADER_FILES string "List of space separated microcode header files with the path" depends on CPU_MICROCODE_CBFS_EXTERNAL_HEADER diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.inc index a072a8b..ec2f19f 100644 --- a/src/cpu/Makefile.inc +++ b/src/cpu/Makefile.inc @@ -13,9 +13,7 @@ ## Rules for building the microcode blob in CBFS ################################################################################
-ifneq ($(CONFIG_CPU_MICROCODE_MULTIPLE_FILES), y) cbfs-files-$(CONFIG_USE_CPU_MICROCODE_CBFS_BINS) += cpu_microcode_blob.bin -endif
ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) cbfs-files-y += cpu_microcode_blob.bin
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47709 )
Change subject: src/cpu: Remove unused symbols ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47709 )
Change subject: src/cpu: Remove unused symbols ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47709 )
Change subject: src/cpu: Remove unused symbols ......................................................................
src/cpu: Remove unused symbols
Remove the unused Kconfig symbol CPU_MICROCODE_MULTIPLE_FILES.
Change-Id: I18115e07694658a2f77c447d3ab5c899c1bdcc61 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47709 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/Kconfig M src/cpu/Makefile.inc 2 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig index 933e50f..297b1a1 100644 --- a/src/cpu/Kconfig +++ b/src/cpu/Kconfig @@ -111,7 +111,6 @@ config CPU_MICROCODE_CBFS_EXTERNAL_BINS bool "Include external microcode binary" select USE_CPU_MICROCODE_CBFS_BINS - depends on !CPU_MICROCODE_MULTIPLE_FILES help Select this option if you want to include external binary files in the CPUs native format. They will be included as a separate @@ -128,7 +127,6 @@
config CPU_MICROCODE_CBFS_EXTERNAL_HEADER bool "Include external microcode header files" - depends on !CPU_MICROCODE_MULTIPLE_FILES help Select this option if you want to include external c header files containing the CPU microcode. This will be included as a separate @@ -179,12 +177,6 @@
endchoice
-config CPU_MICROCODE_MULTIPLE_FILES - bool - help - Select this option to install separate microcode container files into - CBFS instead of using the traditional monolithic microcode file format. - config CPU_MICROCODE_HEADER_FILES string "List of space separated microcode header files with the path" depends on CPU_MICROCODE_CBFS_EXTERNAL_HEADER diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.inc index a072a8b..ec2f19f 100644 --- a/src/cpu/Makefile.inc +++ b/src/cpu/Makefile.inc @@ -13,9 +13,7 @@ ## Rules for building the microcode blob in CBFS ################################################################################
-ifneq ($(CONFIG_CPU_MICROCODE_MULTIPLE_FILES), y) cbfs-files-$(CONFIG_USE_CPU_MICROCODE_CBFS_BINS) += cpu_microcode_blob.bin -endif
ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) cbfs-files-y += cpu_microcode_blob.bin
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)