Change in coreboot[master]: soc/intel/apollolake: Set sdcard card detect (CD) host owner...

[Venkateswarlu V Vinjamuri (Code Review)]

Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )

Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/18947/6/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/nvs.h:

Line 44: 	uint8_t		hsad; /* 0x2F - HOSTSW_REG address */
> But you can calculate out the dw0 by knowing the community offset and multi
> It's possible to do that way as well. 
> But we've already implemented generic functions in gpiolib.asl to extract port address and offset to work across all gpio communities. This logic is fully validated. 
> Do we really need to remove that and add suggested logic? please let me know.