Attention is currently required from: Alexander Couzens, Felix Singer, Maciej Pijanowski, Michał Kopeć, Paul Menzel.
Angel Pons has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Coffee Lake)
......................................................................
Patch Set 13: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80609/comment/e76786c6_70958358?usp... :
PS10, Line 26: - PCIe x8 port
Thanks for this testing effort. Added some note on this in documentation.
Looks good
File Documentation/mainboard/lenovo/m920q.md:
https://review.coreboot.org/c/coreboot/+/80609/comment/0dc6d083_b464a0c6?usp... :
PS10, Line 85: - PCIe x8 port
This port works, but see comments about riser problems.
Done
File src/mainboard/lenovo/m920q/gpio.c:
PS13:
To address Felix's comments, I would just remove all occurrences of `\t/* GPIO */`. Yes, it would remove a few more comments, but they're not that useful anyway (one can see something is used as a GPIO from the pad macro)
File src/mainboard/lenovo/m920q/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/ca02c410_a8de2d14?usp... :
PS10, Line 12: 0x411111f0
FWIW, these changes are as per CB:82394 and should be reproducible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80609?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4
Gerrit-Change-Number: 80609
Gerrit-PatchSet: 13
Gerrit-Owner: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 24 Jun 2024 21:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com