Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Patrick Rudolph, Paul Menzel, niehaitao@bytedance.com.
Yiwei Tang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75722/comment/e01c0cff_951e09d4 : PS3, Line 4: TangYiwei
Please add a space, and put the surname at the end. […]
Done
https://review.coreboot.org/c/coreboot/+/75722/comment/1a7923a1_1ddb1087 : PS3, Line 9: bd_egs
In `src/mainboard/bytedance/bd_egs/board_info.txt` it’s named Eaglestream. […]
Eaglestream is intel platform. Change our board_info.txt board name.
https://review.coreboot.org/c/coreboot/+/75722/comment/53220395_238937af : PS3, Line 11:
Please look at commit 30e743e7cc7f (mb/ibm: Add 4 SPR sockets server board IBM SBP1), Ie21c744224e8d […]
Done
https://review.coreboot.org/c/coreboot/+/75722/comment/bc31ccb7_0ed43015 : PS3, Line 14: Yuuka_Kazami caolong01@inspur.com : Co-authored-by: wanghao11 wanghao11@inspur.com : Co-authored-by: lanchenyu lanchenyu@inspur.com : Co-authored-by: laykong lay.kong@intel.com : Co-authored-by: kehong-intel kehong.chen@intel.com : Co-authored-by: ziang ziang.wang@intel.com : Co-authored-by: weidong weidong.wd@bytedance.com : Co-authored-by: lichenchen.carl
It’d be great if you spelled the full names as the other names.
Done
File src/mainboard/bytedance/bd_egs/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75722/comment/22b0dedd_de04ce86 : PS3, Line 25: * For ArcherCity CRB, only SUART1 is used.
Looks copy-pasted.
Done