Change in coreboot[master]: [RFC] device: Introduce new method for setting device states

[Nico Huber (Code Review)]

Attention is currently required from:  Felix Singer, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] device: Introduce new method for setting device states
......................................................................


Patch Set 17:

(1 comment)

File src/soc/intel/skylake/fspdevmap.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/cb70767b_aa4c322e 
PS13, Line 15: devmap[i].inverted ^ dev->enabled
> nit: I would exchange them, because we're inverting the dev state, not the invert field.
> Hmm, I just noticed the same order in

inverting the dev state

and

    inverted ^ dev->enabled



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3
Gerrit-Change-Number: 52493
Gerrit-PatchSet: 17
Gerrit-Owner:  Felix Singer <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention:  Felix Singer <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Furquan Shaikh <[e-mail]>
Gerrit-Attention: Matt DeVillier <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Michael Niewöhner <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Felix Held <[e-mail]>
Gerrit-Comment-Date: Sat, 01 May 2021 10:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner <[e-mail]>
Gerrit-MessageType: comment