Attention is currently required from: Marc Jones, Johnny Lin, Christian Walter, Angel Pons, Subrata Banik, Patrick Rudolph, Deomid "rojer" Ryabkov.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51230 )
Change subject: soc/intel/xeon_sp/cpx: Set the MRC "cold boot required" status bit
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi Subrata
I wonder is this design applies to client side FSP . If that is the case, we should make this logic generic to FSP 2.0; otherwise, we will have it in soc.intel/xeon_sp.
Note that this code change is backward compatible with older CPX-SP FSPs, but recent CPS-SP FSPs without this code change suffers boot performance issue.
Thanks,
Jonathan
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c4191d2fa2e0203b3464dcf40d845ede5f14c6b
Gerrit-Change-Number: 51230
Gerrit-PatchSet: 4
Gerrit-Owner: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 17:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment