Attention is currently required from: Alexander Couzens, Felix Held, Paul Menzel, Pratikkumar V Prajapati.
Angel Pons has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84186?usp=email )
Change subject: util/inteltool: pci ids are 16 bit
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84186/comment/1f460be5_977883d6?usp... :
PS1, Line 7: pci ids are 16 bit
util/inteltool: Fix format for PCI vendor/device IDs
https://review.coreboot.org/c/coreboot/+/84186/comment/542aa157_4b6c584b?usp... :
PS1, Line 8:
Maybe print log before and after?
I don't think it's needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I87804a63f04b7461d348a245531542776575eb7a
Gerrit-Change-Number: 84186
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 02 Sep 2024 17:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org