Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83409?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/hatch/var/jinlon: Replace hardcoded address with device type ......................................................................
mb/google/hatch/var/jinlon: Replace hardcoded address with device type
Eliminates the use of a magic number, and the resulting DID entry in the _DOD method is the same. The first entry was already changed in commit 1810a1841528 ("mb/google/*: Replace use of gfx/generic addr field with display type"), this one was missed.
TEST=build/boot google/jinlon w/o privacy screen, dump SSDT and verify DID entry is unchanged but _ADR is now correct (since the DID flags are not part of the address field).
Change-Id: Ief22928ea831d4cb5b483406ac388218a97ad98b Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83409 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 81e7883..88753de 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -85,7 +85,7 @@ register "device_count" = "1" register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" device generic 1 alias no_eps on end end end