Attention is currently required from: Martin Roth. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52900 )
Change subject: mb/google/mancomb: Update AMDFW config file ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/amdfw.cfg:
https://review.coreboot.org/c/coreboot/+/52900/comment/93f0e62d_657d9331 PS1, Line 37: PSP_PMUI_FILE1 TypeId0x65_Appb_CZN_1D_Ddr4_Udimm_Dmem.csbin : PSP_PMUD_FILE2 TypeId0x64_Appb_CZN_2D_Ddr4_Udimm_Imem.csbin It looks like you transposed the I and D in col. 8, comparing to soc//cezanne. So it looks like your Instr. file is Dmem and the Data file is Imem.