Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59295 )
Change subject: soc/mediatek: move i2c function to common folder
......................................................................
Patch Set 6:
(2 comments)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/59295/comment/cf88b96a_6a675b24
PS5, Line 35: { /* do nothing */ }
Could you take the chance to fix this as well?
Done
https://review.coreboot.org/c/coreboot/+/59295/comment/ed605311_cb167ee1
PS5, Line 549: This function is only used from MT8195.
No need to mention this in the common file.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261
Gerrit-Change-Number: 59295
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 01:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment