Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83633?usp=email )
Change subject: ec/starlabs/merlin: Don't report the battery serial number to ACPI ......................................................................
ec/starlabs/merlin: Don't report the battery serial number to ACPI
Reporting the battery serial number to ACPI causes Windows to say there isn't a battery present. As the serial number is as useful as waterproof towel, don't do it.
Change-Id: I97a28b1d8d7bb45ea4790c8125cd3c1bc52ee5f9 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/83633 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/ec/starlabs/merlin/acpi/battery.asl 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/acpi/battery.asl b/src/ec/starlabs/merlin/acpi/battery.asl index e6b0964..ee800ed 100644 --- a/src/ec/starlabs/merlin/acpi/battery.asl +++ b/src/ec/starlabs/merlin/acpi/battery.asl @@ -48,9 +48,6 @@ SBIF [6] = B1DC / 20 // 5% SBIF [7] = B1DC / 500 // 0.2% SBIF [8] = B1DC / 500 // 0.2% - If (B1SN != 0xffff) { - SBIF [10] = B1SN - } } Return (SBIF) } @@ -101,9 +98,6 @@ } XBIF [14] = B1DC / 500 // 0.2% XBIF [15] = B1DC / 500 // 0.2% - If (B1SN != 0xffff) { - XBIF [17] = B1SN - } } Return (XBIF) }