Mike Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32100
Change subject: mb/google/arcada: Update general IRQ name ......................................................................
mb/google/arcada: Update general IRQ name
Touchscreen lost function after boot with stylus touching the screen
BUG=b:128554235
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I692fc6f245b7fade67862da4986a83d11a2cd51f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/32100/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 6f167c2..716fb3f 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -300,7 +300,7 @@ chip drivers/i2c/hid register "generic.hid" = ""WCOM48E2"" register "generic.desc" = ""Wacom Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" register "generic.enable_delay_ms" = "5"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32100
to look at the new patch set (#2).
Change subject: mb/google/arcada: Modify touch screen IRQ ......................................................................
mb/google/arcada: Modify touch screen IRQ
Touchscreen lost function after boot with stylus touching the screen
BUG=b:128554235
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I692fc6f245b7fade67862da4986a83d11a2cd51f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/32100/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32100 )
Change subject: mb/google/arcada: Modify touch screen IRQ ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32100/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32100/2//COMMIT_MSG@7 PS2, Line 7: mb/google/arcada: Modify touch screen IRQ
Make touchscreen IRQ level triggered
Hello Lijian Zhao, Duncan Laurie, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32100
to look at the new patch set (#3).
Change subject: mb/google/arcada: Make touchscreen IRQ level triggered ......................................................................
mb/google/arcada: Make touchscreen IRQ level triggered
Touchscreen lost function after boot with stylus touching the screen
BUG=b:128554235
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I692fc6f245b7fade67862da4986a83d11a2cd51f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/32100/3
Mike Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32100 )
Change subject: mb/google/arcada: Make touchscreen IRQ level triggered ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
(1 comment)
Done
https://review.coreboot.org/#/c/32100/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32100/2//COMMIT_MSG@7 PS2, Line 7: mb/google/arcada: Modify touch screen IRQ
Make touchscreen IRQ level triggered
Done
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32100 )
Change subject: mb/google/arcada: Make touchscreen IRQ level triggered ......................................................................
Patch Set 3: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32100 )
Change subject: mb/google/arcada: Make touchscreen IRQ level triggered ......................................................................
mb/google/arcada: Make touchscreen IRQ level triggered
Touchscreen lost function after boot with stylus touching the screen
BUG=b:128554235
Signed-off-by: Mike Hsieh mike_hsieh@wistron.corp-partner.google.com Change-Id: I692fc6f245b7fade67862da4986a83d11a2cd51f Reviewed-on: https://review.coreboot.org/c/coreboot/+/32100 Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 6f167c2..716fb3f 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -300,7 +300,7 @@ chip drivers/i2c/hid register "generic.hid" = ""WCOM48E2"" register "generic.desc" = ""Wacom Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" register "generic.enable_delay_ms" = "5"
-
Duncan Laurie (Code Review) -
Mike Hsieh (Code Review)
-
Paul Menzel (Code Review)