Attention is currently required from: Ashish Kumar Mishra, Martin Roth, Saurabh Mishra, Subrata Banik.
Hello Arthur Heymans, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84142?usp=email
to look at the new patch set (#7).
Change subject: src/include/: Introducing a new BIT_32(x) macro.
......................................................................
src/include/: Introducing a new BIT_32(x) macro.
This new macro addition ensures the shift operation does not
exceed the 32-bit width of the GEN_PMCON_A register.
Details-
On a 64-bit system, 1ul will typically be 64 bits wide.
The left shift can accommodate values of x up to 63 without
overflowing.
But `GEN_PMCON_A` register width is 32-bit hence, adding new BIT_32(x)
to limit the register to max 32-bit width.
Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Signed-off-by: Saurabh Mishra mishra.saurabh@intel.com
---
M src/include/types.h
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84142/7
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84142?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Gerrit-Change-Number: 84142
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com