Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI ......................................................................
Patch Set 18:
(8 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/66992/comment/6ad019ec_22522113 PS14, Line 10: CL:66915
need to add the commit sha and title
Done
https://review.coreboot.org/c/coreboot/+/66992/comment/8efead9d_108c0ecb PS14, Line 12: TEST=None yet. Awaiting Hardware
do we have correct device now to test ?
Done
https://review.coreboot.org/c/coreboot/+/66992/comment/60448b51_95b7f168 PS14, Line 12: TEST=None yet. Awaiting Hardware
do we have correct device now to test ?
Done
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/5f9d2024_b6a836c2 PS14, Line 435: A20
nit: please submit a separate CL to fix this typo
Ack
https://review.coreboot.org/c/coreboot/+/66992/comment/7eb49a5c_88257e1f PS14, Line 387: PAD_CFG_GPO(GPP_B11, 1, DEEP),
This was a copy paste over from Brya where we couldn't change bootblock anymore? This isn't directl […]
Done
https://review.coreboot.org/c/coreboot/+/66992/comment/9cdc9c3a_40fe5d05 PS14, Line 396: /* GPP_C23 : [] ==> FP_RST_ODL */ : PAD_CFG_GPO(GPP_C23, 0, DEEP),
line number 444, already drove this signal low. […]
Done
https://review.coreboot.org/c/coreboot/+/66992/comment/f8160723_8fb37a2e PS14, Line 439: /* GPP_B11 : [] ==> EN_FP_PWR */ : PAD_CFG_GPO(GPP_B11, 0, DEEP),
do u know the default state of this signal ?
Not sure, but followed the same procedure as in https://review.coreboot.org/c/coreboot/+/66915 to keep it powered off till the kernel driver takes over to power sequence it.
https://review.coreboot.org/c/coreboot/+/66992/comment/3dabaef8_c6465912 PS14, Line 443:
use tab
Done
-
Eran Mitrani (Code Review)