Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI ......................................................................
Patch Set 14:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66992/comment/11b3dbe5_eed4e862 PS14, Line 10: CL:66915 need to add the commit sha and title
https://review.coreboot.org/c/coreboot/+/66992/comment/ea82bbde_b4d0f8d3 PS14, Line 12: TEST=None yet. Awaiting Hardware do we have correct device now to test ?
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/5b58dda2_804fde35 PS14, Line 435: A20 nit: please submit a separate CL to fix this typo
https://review.coreboot.org/c/coreboot/+/66992/comment/10743fbe_97f7dc99 PS14, Line 396: /* GPP_C23 : [] ==> FP_RST_ODL */ : PAD_CFG_GPO(GPP_C23, 0, DEEP), line number 444, already drove this signal low. what is the point of doing the same again?
https://review.coreboot.org/c/coreboot/+/66992/comment/643eb359_50f98788 PS14, Line 439: /* GPP_B11 : [] ==> EN_FP_PWR */ : PAD_CFG_GPO(GPP_B11, 0, DEEP), do u know the default state of this signal ?
https://review.coreboot.org/c/coreboot/+/66992/comment/7d358b9a_e85d0194 PS14, Line 443: use tab