Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60582 )
Change subject: ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax ......................................................................
ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax
Replace `Increment(a)` with `a++`.
Change-Id: Ib2154767cfc547ca9bd0a23937d50689be13fbcf Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60582 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/ec/smsc/mec1308/acpi/battery.asl M src/ec/smsc/mec1308/acpi/ec.asl 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 2aa5ace..59d6c4f 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -135,7 +135,7 @@ Store (SWAB (BTPR), Local1) If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { Xor (Local1, 0xFFFF, Local1) - Increment (Local1) + Local1++ } Store (Local1, PBST[1])
@@ -145,7 +145,7 @@ Store (SWAB (BTRA), Local1) If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { Xor (Local1, 0xFFFF, Local1) - Increment (Local1) + Local1++ }
If (BFWK && ACEX && LNot (Local0)) { diff --git a/src/ec/smsc/mec1308/acpi/ec.asl b/src/ec/smsc/mec1308/acpi/ec.asl index c7b180d..23b4c69 100644 --- a/src/ec/smsc/mec1308/acpi/ec.asl +++ b/src/ec/smsc/mec1308/acpi/ec.asl @@ -69,7 +69,7 @@ // Force a read of CPU temperature Store (CPUT, Local0) /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ }
PowerResource (FNP0, 0, 0)