Attention is currently required from: Felix Singer, Jason Glenesk, Raul Rangel, Martin L Roth, Angel Pons.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67319 )
Change subject: util/release/build-release: Fix style issues
......................................................................
Patch Set 2:
(3 comments)
File util/release/build-release:
https://review.coreboot.org/c/coreboot/+/67319/comment/8f9856e2_5d9e3d1c
PS1, Line 12: set -e
If you wanted to make it even more robust: […]
Looks reasonable. I'll add it in a follow-on since that's a more functional change.
https://review.coreboot.org/c/coreboot/+/67319/comment/eb08b69a_88cd5c77
PS1, Line 65: --
Why the `--`?
No longer needed - removed.
https://review.coreboot.org/c/coreboot/+/67319/comment/52f712e6_55a9d437
PS1, Line 80: cat "coreboot-${VERSION_NAME}/.coreboot-version" | tr "-" " "
nit: `tr "-" " " < "coreboot-${VERSION_NAME}/. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e79afc8d725e86ddbf7f4eb4685bed190c20738
Gerrit-Change-Number: 67319
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 18:06:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment