Change in coreboot[master]: src/soc/intel/common/itss: Add support to get interrupt table for PCI...
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )
Change subject: src/soc/intel/common/itss: Add support to get interrupt table for PCI devices ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34089/7/src/soc/intel/common/block/... File src/soc/intel/common/block/itss/irq.c:
https://review.coreboot.org/c/coreboot/+/34089/7/src/soc/intel/common/block/... PS7, Line 144: }
Yeah, that does not seem to be a valid assumption, although I am seeing the IRQ being successfully p […]
From the rest of the CLs, it seems FSP is passing the int_cfg_ptr buffer and also the int_num as an out parameter to get the size i.e. number of interrupt config entries being returned.
If the FSP can pass int_num as an in/out parameter, that would be ideal where we know the number of entries that buffer can hold and the number of entries being returned.
One thing I am not clear with your approach is whether the caller will copy the data from the static array that this function is returning into the buffer provided by FSP. If so, then we still have the problem at the caller location. Please correct me if I did not understand correctly.
-
Karthik Ramasubramanian (Code Review)