Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 )
Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/google/volteer/variants/collis/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/699eb625_22c0da38 PS2, Line 8: struct device *codec = DEV_PTR(audio_codec); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/8cc00456_83b17327 PS2, Line 8: struct device *codec = DEV_PTR(audio_codec); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/f15ed7f8_a26b445c PS2, Line 9: struct drivers_i2c_generic_config *config; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/f576fe4f_a49a1f2d PS2, Line 9: struct drivers_i2c_generic_config *config; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/8ba754e5_8aa08cfb PS2, Line 11: config = codec->chip_info; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136373): https://review.coreboot.org/c/coreboot/+/60415/comment/1b215f3b_546b3e12 PS2, Line 11: config = codec->chip_info; please, no spaces at the start of a line