Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/5ffe7a53_fec3c434 PS2, Line 33: static const struct
I would prefer to keep in this chip header file only because in future this list will grow with re […]
Thanks for sharing this. Yes, we can move this data structure in systemagent.c file. But, in future we need to maintain and keep in sync two different files to update SKUs TDP value, file one systemagent.c (this data structure) and another chip.h as above line #22 enum. We can't move this line #22 enum from chip.h to systemagent.c because it's being used in the same chip.h file at line #97 under soc_intel_meteorlake_config data structure for MTL_POWER_LIMITS_COUNT. If we are fine to maintain two files, I plan to move only this data structure to systemagent.c and submit new version of this patch.