Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin Roth, Nill Ge, Subrata Banik, TangYiwei, Ziang Wang, niehaitao@bytedance.com.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email )
Change subject: arch/x86/smbios: Add weak function for BIOS Vendor in SMBIOS Type0
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Patch like this? […]
Right, but I'm not even sure that the ifdef is required, because the value should always be present in Kconfig after we set it there. You can look at how CONFIG_MAINBOARD_SERIAL_NUMBER is used.
```
config BIOS_VENDOR
string
prompt "SMBIOS BIOS_VENDOR string" if !SMBIOS_PROVIDED_BY_MOBO
default "coreboot"
help
The BIOS_VENDOR string to store in the SMBIOS Type0 table.
```
There's already an SMBIOS section in src/Kconfig, so this fits there, inside the `if GENERATE_SMBIOS_TABLES` block
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75737?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dfcca338ffc48b150c966b9aefcefe928704d24
Gerrit-Change-Number: 75737
Gerrit-PatchSet: 1
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeff Li
lijinfeng01@inspur.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: niehaitao@bytedance.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: niehaitao@bytedance.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Jeff Li
lijinfeng01@inspur.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Jun 2023 16:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment