Attention is currently required from: Johnny Lin, Ed Sharma, Martin Roth.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/0f67df0b_957cf194 PS1, Line 7: commonlib/fsp_relocate: Fix Coverity Issues Pls. refer to these existing coverity related commits: $ git log --oneline | grep -i coverity 94e4961a01 acpi: Fix Coverity Scan report 7777e1c30b ec/google/chromeec: Fix Coverity Scan error (BAD_SHIFT) 423adfb0d3 x86/acpi: Fix Coverity issue CID 1399153 b431833c12 Docs/project_ideas: Add coverity scan cleanup project c75f2d8119 arch/x86/acpi_bert_storage.c: Fix coverity error CID 1395706 013ebbfa58 soc/intel/cannonlake: Fix Coverity Scan report 4461613119 cavium/bdk: Fix coverity and remove hardcoded DRAM speed ded0c77d48 Coverity: Fix CID1393976 f4d81e0385 Coverity: Fix CID1393978 679d624fae Coverity: Fix CID1393979 feefbd7127 soc/intel/cannonlake: Fix Coverity scan error f797a1ac6a riscv: Suppress invalid coverity errors
https://review.coreboot.org/c/coreboot/+/68637/comment/7505b178_657a5773 PS1, Line 9: Recently committed change 1df1cf9 resulted in some Coverity Use [CB: gerrid ID] as the hyper-link.
https://review.coreboot.org/c/coreboot/+/68637/comment/85e98269_f3a97a5c PS1, Line 14: This code is tested with FSP version 33A for DeltaLake boot FSP --> Intel CooperLake-SP FSP 33A, needs to be the full version number.
-
Jonathan Zhang (Code Review)