Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
......................................................................
Patch Set 24:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85128/comment/9d1dd9d8_378f5496?usp... :
PS23, Line 9: Add MT6363 AUXADC driver support.
It’d be great if you elaborated a little.
Done
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/7c5439b0_048827fd?usp... :
PS23, Line 23: AUXADC_AVG_TIME
Please append the unit to the name.
Done
https://review.coreboot.org/c/coreboot/+/85128/comment/5f775e2f_add9134d?usp... :
PS23, Line 24: AUXADC_POLL_TIME
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/85128/comment/9676edd4_347cb071?usp... :
PS23, Line 64: int
enum auxadc_channel
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a
Gerrit-Change-Number: 85128
Gerrit-PatchSet: 24
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 09:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yidi Lin
yidilin@google.com